Fix: Custom properties are deleted even if the option is off#298
Fix: Custom properties are deleted even if the option is off#298cl3m3c7 wants to merge 9 commits intoMustard2:masterfrom
Conversation
|
Third time might be the one. :D I got the old version to check, and it did have a HUGE issue: it also deleted drivers unrelated to the UI (like corrective shape keys manually set, not the Daz ones). For this new PR, did you use the same driver check and delete functions? Because if yes, we might get the same issue also in this version. If you have an email or something, I can send you the video with the issue. |
|
you can put the video here! you can zoom out NSFW parts if there are any or do you have other concerns (copyright materials ...)? if not possible, you can send me a message in twitter (@cl3m3c7) |
|
Both the reasons. I'll send it on twitter |
|
Ah I can't send you messages. :( |
…ard2#290) * Refine mask modifier name matching to use endswith Updated mask modifier checks in both ops_complete_outfit_visibility.py and ops_visibility.py to use mod.name.endswith(obj.name) instead of checking for substring presence. This change ensures more precise matching of modifier names to object names. * Add customizable date format for model version Introduces options to select the date format for the model version, including new properties for date format and manual date entry. Updates the configuration logic to use the selected format and handle invalid dates gracefully. UI is updated to allow users to choose the date format and set the date vector if enabled. * Apply suggestions from code review * Update modifier name check to use endswith method * Refactor outfit visibility operator in Blender * Apply suggestions from code review * Apply suggestion from @Mustard2 --------- Co-authored-by: Mustard <60780948+Mustard2@users.noreply.github.com>
|
I just had the time to try this fix. I cloned the branch here, and trying the same procedure as in #285, I get the same wrong behavior unfortunately. :( |
- Enhancement: The Simplify tool has been completely rewritten to support new features and solve some longstanding issues (Mustard2#300 Mustard2#304). - Feature (Mustard2#149 Mustard2#187): Float subtype and step can now be set in the custom property settings. - Enhancement (Mustard2#290): The Version Date can now be overridden and customized with different date formats (thanks to @Ckang3D). - Fix: An error with morph presets when using boolean values might occur. - Fix (Mustard2#290): Fixed an issue on the outfit Mask modifiers that might be enabled/disabled erroneously if outfits with names that are substrings of others are used (thanks to @Ckang3D).
|
in my testing it works, could you ask him to test and see if it fixed it for him? |
- Fix: Fix error when using the Custom Properties settings with Color properties.
|
Uhm ok let me retry then :D |
|
Sorry again for the NSFW, I'm trying as the user reported (we remove everything after the things are fixed). I downloaded the branch here, installed and removed all other MustardUI addon I had, restarted Blender (and checked that your version is indeed the one loaded), and tried exactly the same steps as Moku reported. |
|
Ok I found the issue here. Essentially some paths have been updated from Blender 4.5 to Blender 5.0 # Before
bpy.data.shape_keys["Key.004"].key_blocks["Up Right"].value
# After
bpy.data.shape_keys["Ashley Body"].key_blocks["Up Right"].valueI am not sure if your fix can detect also this behaviour, that is the |
that's the thing which should be tested. if look at the end of the video in the original issue, he checked the driver's property, it was red (deleted). the reset in the value was expected, because there is the default value reset when cleaning up. did you get what I am trying to say? not sure if I phrase it correctly 😅 |
|
Yes but then with your fix it shouldn't delete those custom properties if it's working. The driver becomes red exactly because the custom properties are deleted even if the fix should in principle prevent it. This is what happens with this current branch. 
|
|
In the meanwhile I also added a check for the driver path issue. 
|
|
@cl3m3c7 I created a co-authored commit to introduce this directly in version 2026.4.0, so it will also appear as you contributed with those lines too :) I added an option to decide whether to remove or not the custom properties. Talking with Moku, he set the wrong default value and changed the expression of the driver, so it was a combination of different stuffs that created the issue. Not something that we could really have any control on tbh. |
|
wait, I will record something to show you what I meant |
|
In the meanwhile I added you as collaborator, so I can assign you to the different MR. :) When you have time, accept the invitation. |
|
I will send it in twitter |
|
Ok got it, it's the same behavior I got. Should be fine for now. :) |
|
does is solve the issue or I misunderstood the issue again? 😟 |
|
No this time I think everything is fine, I also wasn't sure about the issue. This was a rare combination of different stuffs going wrong at the same time, plus user custom tweaks. :D |
|
ok 👍🏼 |
|
this needs to be rebased on top of the latest changes before merge |
|
I already imported all the fixes manually, since I was also making some tests myself. I think it's easier to close this and open a new one with just the ruff changes, otherwise it's also difficult to review due to the linting noise. |
3 participants
Fixes #285