RFC: fix CI, add PyPI publish action, poetry 1.6.1#9
Merged
MartinCura merged 20 commits intomasterfrom Oct 19, 2023
Merged
Conversation
leo-mansini
changed the title
MartinCura
reviewed
Oct 18, 2023
|
|
||
| jobs: | ||
| pypi-publish: | ||
| if: startsWith(github.ref, 'refs/tags/') |
Contributor
There was a problem hiding this comment.
this makes sure that this runs only when a tag is pushed, right?
Contributor
Author
There was a problem hiding this comment.
Yes, I couldn't find a more robust way to do it, but it's the suggested way in the action documentation and in the python guide.
Contributor
There was a problem hiding this comment.
great, adjusted it a bit based on the action's recommendations
Co-authored-by: martín <MartinCura@users.noreply.github.com>
leo-mansini
had a problem deploying
to
testpypi
GitHub Actions
Failure
leo-mansini
had a problem deploying
to
testpypi
GitHub Actions
Failure
leo-mansini
had a problem deploying
to
testpypi
GitHub Actions
Failure
...maybe missing API token for prod publish if not doing Trusted Publishing
leo-mansini
commented
Oct 19, 2023
Contributor
Author
There was a problem hiding this comment.
@MartinCura Can't approve as I opened the PR but consider it approved. 📦 🐍
MartinCura
approved these changes
Oct 19, 2023
MartinCura
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds github action to publish to pypi. Also tries with testpypi on every push (not just a tag release).