Merged
Conversation
Replace mutable version tags (e.g. @v4) with immutable full-length commit SHA digests across all seven workflow files. Each pin retains a human-readable comment (e.g. # v4) so the intended version is still obvious at a glance. Actions pinned: - actions/checkout@v4 → @11bd71901bbe5b1630ceea73d27597364c9af683 - actions/setup-node@v4 → @49933ea5288caeca8642d1e84afbd3f7d6820020 - actions/cache@v4 → @0057852bfaa89a56745cba8c7296529d2fc39830 - actions/github-script@v7 → @f28e40c7f34bde8b3046d885e986cb6290c5673b - actions/dependency-review-action@v4 → @a6993e2c61fd5dc440b409aa1d6904921c5e1894 - dtolnay/rust-toolchain@stable → @3c5f7ea28cd621ae0bf5283f0e981fb97b8a7af9 - Swatinem/rust-cache@v2 → @42dc69e1aa15d09112580998cf2ef0119e2e91ae Workflows updated: - abi-snapshot.yml - audit-check.yml - changelog.yml - ci.yml - commitlint.yml - contract-release.yml - dependency-review.yml Also fixes a structural bug in audit-check.yml where the frontend-audit step was missing its step name and was incorrectly appended to the backend-audit step block.
Introduce .github/workflows/sbom.yml which builds the frontend and backend Docker images in CI and generates an SPDX JSON Software Bill of Materials (SBOM) for each using anchore/sbom-action. - Triggers on push/PR to main or develop when Dockerfiles or package manifests change, and on workflow_dispatch for manual runs - Builds myfans/frontend:ci from frontend/Dockerfile - Builds myfans/backend:ci from backend/Dockerfile - Produces sbom-frontend.spdx.json and sbom-backend.spdx.json - Uploads each SBOM as a workflow artifact retained for 90 days - All actions pinned to full SHA digests (supply-chain hygiene)
- Add Team Ownership section mapping each test area to the responsible GitHub team (@MyFanss/frontend, @MyFanss/backend, @MyFanss/contract) - Add Owner column to the test matrix table so each row has a clear accountable team at a glance - Update CODEOWNERS to add @MyFanss/frontend for /frontend/ and /docs/release/ so smoke test matrix changes require frontend review
|
@josunday002 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test Plan
Automated tests added or updated
backend/src/**/*.spec.ts) — service/guard/decorator logic in isolationbackend/test/**/*.e2e-spec.ts) — HTTP round-trips with mocked infrastructurefrontend/src/**/*.test.{ts,tsx}) — React component behaviourfrontend/e2e/**/*.spec.ts) — Playwright browser flowscontract/) — Soroban/Rust unit tests viacargo testHow to run the tests locally
Manual verification checklist
cd backend && npm run lint/cd frontend && npm run lintRelated issues
Notes for reviewers
closes #713