[TASK] Avoid heredoc in a test #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added
the
developer-specific
oliverklee
force-pushed
the
cleanup/heredoc
branch
2 times, most recently
from
dcb8fce to
1f0aa82
Compare
JakeQZ
requested changes
Dec 4, 2025
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
I'd rather the \ns at the end of the line. It seems a bit illogical otherwise.
This allows the testcase being autoformatted without breaking the tests for PHP 7.2 https://www.php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc
oliverklee
force-pushed
the
cleanup/heredoc
branch
from
1f0aa82 to
6a27100
Compare
oliverklee
force-pushed
the
cleanup/heredoc
branch
from
6a27100 to
44a7d75
Compare
JakeQZ
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the testcase being autoformatted without breaking the tests for PHP 7.2
https://www.php.net/manual/en/language.types.string.php#language.types.string.syntax.heredoc