Skip to content

[CLEANUP] Tighten consumeUntil $comments parameter type #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverklee merged 1 commit into from
Dec 9, 2025
Merged

[CLEANUP] Tighten consumeUntil $comments parameter type #1418

oliverklee merged 1 commit into from
Dec 9, 2025

Conversation

@JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Dec 9, 2025

No description provided.

@JakeQZ JakeQZ requested a review from oliverklee December 9, 2025 12:39
@JakeQZ JakeQZ self-assigned this Dec 9, 2025
@JakeQZ JakeQZ added the cleanup label Dec 9, 2025
@coveralls
Copy link

coveralls commented Dec 9, 2025

Coverage Status

coverage: 62.804%. remained the same
when pulling 1d40e28 on cleanup/consumeuntil-comments-type
into d1af3bb on main.

@JakeQZ JakeQZ mentioned this pull request Dec 9, 2025
Merged
oliverklee
oliverklee approved these changes Dec 9, 2025
View reviewed changes
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@oliverklee oliverklee merged commit a5d1172 into main Dec 9, 2025
23 checks passed
@oliverklee oliverklee deleted the cleanup/consumeuntil-comments-type branch December 9, 2025 12:43
@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Dec 9, 2025

Seems that DeclarationBlock::parseSelectors() is the only place where the $comments parameter of comsumeUntil() is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels

cleanup

Projects

None yet

Milestone

9.2.0: New features, bug fixes and de...

Development

Successfully merging this pull request may close these issues.

4 participants

@JakeQZ @coveralls @oliverklee