[TASK] Use SelectorComponent and Combinator in Selector::parse()#1471
Merged
oliverklee merged 1 commit intomainfrom Feb 5, 2026
Merged
[TASK] Use SelectorComponent and Combinator in Selector::parse()#1471oliverklee merged 1 commit intomainfrom
SelectorComponent and Combinator in Selector::parse()#1471oliverklee merged 1 commit intomainfrom
Conversation
JakeQZ
added
the
refactor
JakeQZ
added a commit
that referenced
this pull request
Jan 23, 2026
Instead have the comments array passed by reference to be appended to. This avoids various methods having to do an `array_merge`, and knowing if any whitespace was consumed will be needed for #1471.
JakeQZ
added a commit
that referenced
this pull request
Jan 23, 2026
Instead have the comments array passed by reference to be appended to. This avoids various methods having to do an `array_merge`, and knowing if any whitespace was consumed will be needed for #1471.
JakeQZ
added a commit
that referenced
this pull request
Jan 23, 2026
Instead, have the comments array passed by reference to be appended to. This avoids various methods having to do an `array_merge`. Also, knowing if any whitespace was consumed will be needed for #1471.
JakeQZ
added a commit
that referenced
this pull request
Jan 24, 2026
Instead, have the comments array passed by reference to be appended to. This avoids various methods having to do an `array_merge`. Also, knowing if any whitespace was consumed will be needed for #1471.
JakeQZ
added a commit
that referenced
this pull request
Jan 24, 2026
Instead, have the comments array passed by reference to be appended to. This avoids various methods having to do an `array_merge`. Also, knowing if any whitespace was consumed will be needed for #1471.
JakeQZ
added a commit
that referenced
this pull request
Jan 24, 2026
Instead, have the comments array passed by reference to be appended to. This avoids various methods having to do an `array_merge`. Also, knowing if any whitespace was consumed will be needed for #1471.
JakeQZ
force-pushed
the
task/selector-parts
branch
4 times, most recently
from
30ded22 to
a17903b
Compare
oliverklee
pushed a commit
that referenced
this pull request
Jan 24, 2026
Instead, have the comments array passed by reference to be appended to. This avoids various methods having to do an `array_merge`. Also, knowing if any whitespace was consumed will be needed for #1471.
JakeQZ
force-pushed
the
task/selector-parts
branch
3 times, most recently
from
ac7799c to
ae72fe6
Compare
JakeQZ
changed the title
SelectorPart interface and classesSelectorComponetn interface and classes
JakeQZ
changed the title
SelectorComponetn interface and classesSelectorComponent interface and classes
JakeQZ
force-pushed
the
task/selector-parts
branch
2 times, most recently
from
a93a1be to
d9a996e
Compare
JakeQZ
force-pushed
the
task/selector-parts
branch
3 times, most recently
from
1bde1f8 to
7a6b49f
Compare
JakeQZ
changed the title
SelectorComponent interface and classesSelectorComponent and Combinator in Selector::parse()
JakeQZ
force-pushed
the
task/selector-parts
branch
from
7a6b49f to
2645682
Compare
JakeQZ
modified the milestones:
10.0.0: Clean up things, rework the API,
9.2.0: New features, bug fixes and deprecations
JakeQZ
force-pushed
the
task/selector-parts
branch
from
2645682 to
4e2da6f
Compare
Ultimately `Selector` will be represented by instances of these classes rather than a string. This change is a stepping-stone towards that goal, to use the parsing functionality of those classes, but for now just converting the parsed result to a single string for internal representation. Part of #1325.
JakeQZ
force-pushed
the
task/selector-parts
branch
from
4e2da6f to
24aa508
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultimately
Selectorwill be represented by instances of these classes rather than a string.This change is a stepping-stone towards that goal, to use the parsing functionality of those classes, but for now just converting the parsed result to a single string for internal representation.
Part of #1325.