[TASK] Disable some rules from Rector Type Perfect#1575
Merged
Conversation
The two type-narrowing rules tend to have too many false positives at the moment.
oliverklee
added
the
developer-specific
|
coverage: 72.927%. remained the same — task/type-perfect-rules into main |
JakeQZ
approved these changes
Apr 19, 2026
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
We should revisit this in future and reenable type narrowing. But in the meantime, there are issues with it:
- It does not seem to play well with union types -
- We should redesign the API to avoid union types, perhaps introducing classes to wrap the type;
- The warning messages are rather cryptic, identifying the callee as the source of the problem, rather than the caller, making them sometimes almost impossible to diagnose -
- This needs improvement in TypePerfect or PHPStan or whatever is obfuscating the details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two type-narrowing rules tend to have too many false positives at the moment.