[TASK] Add rector to composer.json with a simple null-config #546
Conversation
oliverklee
left a comment
oliverklee
left a comment
There was a problem hiding this comment.
Thanks for contributing this PR, @ziegenberg! ❤️
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
Adding rector as a development dependency enables us to do automatic refactorings. Initially this comes with a simple null-config, that does not do much but run rector, so following the suggested integration path of "taking it slow" [1]. Helps with MyIntervals#432 [1] https://getrector.com/documentation/integration-to-new-project Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
|
I addressed your comments, rebased onto the current main and force-pushed my changes. Please let me know if you would rather have fixup commits for later squashing them. |
Yes, I'd prefer that as that makes re-reviewing a PR a bit easier. Thanks for asking! |
|
I addressed the last two comments regarding the Composer commands in a fixup commit. If you're done reviewing I can quash them. |
Thanks! There's no need, though - GitHub allows me to squash all commits of a PR when I merge it. |
oliverklee
left a comment
oliverklee
left a comment
There was a problem hiding this comment.
Looks good. Thanks! 🙏
2 participants
Adding rector as a development dependency enables us to do automatic refactorings. Initially, this comes with a simple null-config, that does not do much but run rector, so following the suggested integration path of "taking it slow" [1].
Helps with #432
[1] https://getrector.com/documentation/integration-to-new-project