[CLEANUP] Rector: Add return type void to function like without any return #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
requested changes
Jun 20, 2024
…eturn This applies the rule AddVoidReturnTypeWhereNoReturnRector. For Details see: https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#addvoidreturntypewherenoreturnrector Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg
force-pushed
the
add-type-coverage-level-13
branch
from
1751503 to
e83c4a5
Compare
JakeQZ
reviewed
Jun 21, 2024
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
Should the Rector config file be updated - specifically to uncomment AddVoidReturnTypeWhereNoReturnRector::class?
oliverklee
approved these changes
Jun 21, 2024
Contributor
Author
IMHO, this can be done at a later stage. First, I'm doing all the CLEANUP and, later, the TASK of configuring the rector. Also, @oliverklee surely wants to have TASK and CLEANUP in different PRs. After this type series, we can set the following config: ->withSets(
[
SetList::TYPE_DECLARATION,
]
) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the rule AddVoidReturnTypeWhereNoReturnRector. For Details see:
https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#addvoidreturntypewherenoreturnrector