Skip to content

[TASK] Deprecate sSpaceAfterListArgumentSeparator being an array #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[TASK] Deprecate sSpaceAfterListArgumentSeparator being an array #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ This project adheres to [Semantic Versioning](https://semver.org/).

### Deprecated

- Deprecate `OutputFormat::sSpaceAfterListArgumentSeparator` being an array
(#876)
- Deprecate `OutputFormat::level()` (#870)

### Removed
Expand Down
4 changes: 3 additions & 1 deletion src/OutputFormat.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ class OutputFormat
public $sSpaceBeforeListArgumentSeparator = '';

/**
* @var string
* #866 `array` is deprecated in version V8.8.0, will be changed to `string` only in V9.0.0.
*
* @var string|array<string, string>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too soon. We need to still allow array until 9.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, was looking at the diff the wrong way round. But...

Can we use @deprecated in the DocBlock here for partial deprecation?

*/
public $sSpaceAfterListArgumentSeparator = '';

Expand Down
2 changes: 2 additions & 0 deletions tests/OutputFormatTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ public function spaceAfterListArgumentSeparator()

/**
* @test
*
* @deprecated #866 since 8.8.0, will be removed in 9.0.0.
*/
public function spaceAfterListArgumentSeparatorComplex()
{
Expand Down