chore: Add Valinor ParamConverter (ported from 2.x)#5
Merged
frankverhoeven merged 5 commits into1.x-devfrom Apr 21, 2022
Merged
chore: Add Valinor ParamConverter (ported from 2.x)#5frankverhoeven merged 5 commits into1.x-devfrom
frankverhoeven merged 5 commits into1.x-devfrom
Conversation
fred-jan
requested review from
a team,
Peter-Weijenburg,
frankverhoeven and
kusozayka
and removed request for
a team
frankverhoeven
approved these changes
Apr 15, 2022
Contributor
frankverhoeven
left a comment
frankverhoeven
left a comment
There was a problem hiding this comment.
One nit, otherwise LGTM
tests/Symfony/Request/ParamConverter/StubValinorParamConverter.php
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change was ported from the
2.xso that it can be used in our PHP 7.4 applications as well.Should be tagged as
1.2