Add clean-architecture package scaffolding (issue #53)#68
Merged
Conversation
Contributor
Author
|
closes #52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
buildcompiler.Description
__init__.py) for the new clean-architecture layout:api,domain,planning,execution,stages,sbol,inventory,adapters,adapters.pudu,adapters.opentrons, andreportingundersrc/buildcompiler/.tests/test_package_scaffolding.pythat imports each new package to validate that core imports resolve without pulling optional automation dependencies.__init__.pyfiles are minimal placeholders (module docstrings only) to avoid introducing behavior or external dependencies.Testing
PYTHONPATH=src python -c "import buildcompiler"andPYTHONPATH=src python -c "import buildcompiler.api; import buildcompiler.domain; import buildcompiler.planning; import buildcompiler.execution; import buildcompiler.stages; import buildcompiler.sbol; import buildcompiler.inventory; import buildcompiler.adapters; import buildcompiler.adapters.pudu; import buildcompiler.adapters.opentrons; import buildcompiler.reporting", both of which succeeded (imports resolved fromsrc).PYTHONPATH=src pytest tests/test_package_scaffolding.pyand the single import-smoke test passed (1 passed).uv run ruff check .but the run failed during environment preparation due to a network/git fetch error for an optional dependency (SBOLInventory), souv-based linting could not complete in this environment; runningruff check .withoutuvwas attempted but revealed pre-existing lint issues outside the scope of this scaffolding PR.PYTHONPATH=srcis acceptable for this scaffolding step; next work items are issue [ISSUE-02] Implement domain enums and result dataclasses #54 (domain enums/dataclasses) followed by [ISSUE-03] Implement BuildOptions option groups #55 (BuildOptions) and no behavioral work is included here.Codex Task