Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces headless simulation failures caused by excessive child-process output by suppressing reb2sac progress-line printing in headless mode, while keeping GUI progress reporting unchanged. It also updates build/infra metadata so modules build more reliably and use secure repository URLs.
Changes:
- Suppress stdout printing of successfully parsed
Time=...progress lines when running headless (noparent), while still printing non-progress diagnostics. - Add explicit dependencies to
dataModels/pom.xmlto support standalone builds and update the osgeo repository URL to HTTPS. - Ignore
.sdkmanrcin.gitignore.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
analysis/src/main/java/edu/utah/ece/async/ibiosim/analysis/Run.java |
Avoids printing progress lines to stdout in headless mode to prevent buffer flooding. |
dataModels/pom.xml |
Adds explicit dependencies for standalone builds and switches osgeo repo URL to HTTPS. |
.gitignore |
Ignores .sdkmanrc. |
Comments suppressed due to low confidence (1)
analysis/src/main/java/edu/utah/ece/async/ibiosim/analysis/Run.java:901
- Progress detection uses
line.contains("Time")and then unconditionally attemptssubstring(line.indexOf('=') + 1, ...). If a non-progress diagnostic line contains the word "Time" but not the expectedTime=...format, this will throw ande.printStackTrace()will emit a stack trace per line, which can still flood stderr in headless runs. Tighten the condition (e.g., requireTime=prefix / regex with=present) and avoid printing full stack traces in this hot loop (log once or include the offending line in a concise message).
if (line.contains("Time")) {
time = Double.parseDouble(line.substring(line.indexOf('=') + 1, line.length()));
isProgress = true;
if (oldTime > time) {
runNum++;
}
oldTime = time;
time += (runNum * properties.getSimulationProperties().getTimeLimit());
double d = ((time * 100) / runTime);
String s = d + "";
double decimal = Double.parseDouble(s.substring(s.indexOf('.'), s.length()));
if (decimal >= 0.5) {
prog = (int) (Math.ceil(d));
} else {
prog = (int) (d);
}
}
}
catch (Exception e) {
e.printStackTrace();
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Responded to each copilot review comment, none of them require any code changes |
cjmyers
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running simulations through SynBioSuite can fail with
ERR_CHILD_PROCESS_STDIO_MAXBUFFERwhen reb2sac progress output overflows Node.js's buffer in iBioSim-API. In headless mode,Run.javadumps every progress line (Time=X) to stdout, but nothing downstream uses them, they just accumulate until the buffer overflows.System.out.printlnfor lines successfully parsed as progress updates. Diagnostic output (warnings, errors) still prints.parent.send().dataModels/pom.xmlso the module builds standalone..sdkmanrcin.gitignore.