-
Notifications
You must be signed in to change notification settings - Fork 1
Add --dry-run option to send and withdraw commands
#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import { describe, expect } from "vitest"; | ||
| import { it } from "./base.js"; | ||
|
|
||
| describe("nova send --dry-run", () => { | ||
| it("prints dry run result with destination", async ({ nova }) => { | ||
| const address = await nova(["address"]); | ||
| const stdout = await nova(["send", "--dry-run", "10", address]); | ||
| expect(stdout).toBe(`Would send 10 to ${address}`); | ||
| }); | ||
|
|
||
| it("prints dry run result without destination", async ({ nova }) => { | ||
| const stdout = await nova(["send", "--dry-run", "5"]); | ||
| expect(stdout).toBe("Would send 5"); | ||
| }); | ||
|
|
||
| it("prints dry run result in JSON format", async ({ nova }) => { | ||
| const address = await nova(["address"]); | ||
| const stdout = await nova(["-j", "send", "--dry-run", "10", address]); | ||
| const result = JSON.parse(stdout); | ||
| expect(result.status).toBe("ok"); | ||
| expect(result.result.dryRun).toBe(true); | ||
| expect(result.result.amount).toBe("10"); | ||
| expect(result.result.to).toBe(address); | ||
| }); | ||
|
|
||
| it("prints dry run result in JSON format without destination", async ({ | ||
| nova, | ||
| }) => { | ||
| const stdout = await nova(["-j", "send", "--dry-run", "5"]); | ||
| const result = JSON.parse(stdout); | ||
| expect(result.status).toBe("ok"); | ||
| expect(result.result.dryRun).toBe(true); | ||
| expect(result.result.amount).toBe("5"); | ||
| expect(result.result.to).toBeUndefined(); | ||
| }); | ||
|
|
||
| it("accepts short flag -d", async ({ nova }) => { | ||
| const address = await nova(["address"]); | ||
| const stdout = await nova(["send", "-d", "10", address]); | ||
| expect(stdout).toBe(`Would send 10 to ${address}`); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import { describe, expect } from "vitest"; | ||
| import { it } from "./base.js"; | ||
|
|
||
| const SOLANA_ADDRESS = "EPjFWdd5AufqSSqeM2qN1xzybapC8G4wEGGkZwyTDt1v"; | ||
|
|
||
| describe("nova withdraw --dry-run", () => { | ||
| it("prints dry run result", async ({ nova }) => { | ||
| const stdout = await nova([ | ||
| "withdraw", | ||
| "--dry-run", | ||
| "10", | ||
| "USDC", | ||
| SOLANA_ADDRESS, | ||
| "solana", | ||
| ]); | ||
| expect(stdout).toBe(`Would withdraw 10 to ${SOLANA_ADDRESS}`); | ||
| }); | ||
|
|
||
| it("prints dry run result in JSON format", async ({ nova }) => { | ||
| const stdout = await nova([ | ||
| "-j", | ||
| "withdraw", | ||
| "--dry-run", | ||
| "10", | ||
| "USDC", | ||
| SOLANA_ADDRESS, | ||
| "solana", | ||
| ]); | ||
| const result = JSON.parse(stdout); | ||
| expect(result.status).toBe("ok"); | ||
| expect(result.result.dryRun).toBe(true); | ||
| expect(result.result.amount).toBe("10"); | ||
| expect(result.result.stablecoin).toBe("USDC"); | ||
| expect(result.result.blockchain).toBe("solana"); | ||
| expect(result.result.to).toBe(SOLANA_ADDRESS); | ||
| }); | ||
|
|
||
| it("errors when stablecoin does not exist for blockchain", async ({ | ||
| nova, | ||
| }) => { | ||
| await expect( | ||
| nova([ | ||
| "-j", | ||
| "withdraw", | ||
| "--dry-run", | ||
| "10", | ||
| "USDA", | ||
| SOLANA_ADDRESS, | ||
| "solana", | ||
| ]), | ||
| ).rejects.toThrow(); | ||
| }); | ||
|
|
||
| it("accepts short flag -d", async ({ nova }) => { | ||
| const stdout = await nova([ | ||
| "withdraw", | ||
| "-d", | ||
| "10", | ||
| "USDC", | ||
| SOLANA_ADDRESS, | ||
| "solana", | ||
| ]); | ||
| expect(stdout).toBe(`Would withdraw 10 to ${SOLANA_ADDRESS}`); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.