Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added BAILOUT to the sparse solver but only using the SuperLU's INFO return value, not the proper ratios of diagonals, and ignoring MAXRATIO. It's allows some solutions that were blocked before but in some cases is still too lenient, allowing solutions that should be stopped by BAILOUT.
Moved the diagonal ratio checking to a separate function that still works the same with the banded solver but will be easier to apply to sparse in future.
Changed the default value of PARAM,BAILOUT from 1 to 0 for consistency with MSC. This doesn't affect the behavior since BAILOUT >=0 means abort and BAILOUT < 0 means continue as before. The manual should be updated to reflect this.
There may still be something wrong with the diagonal ratio checking code because it sometimes shows an error message that indicates it would fail but it continues. Only affects the banded solver because only that uses the diagonal ratio checks.