Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes crashes caused by adding MPCs to SOL 105 (buckling) decks, fixing #192.
All issues revolve around arrays being deallocated or files being deleted when they shouldn't. Buckling runs are particularly vulnerable to that since they effectively run MYSTRAN twice, and many deallocations/closes do not check if we're in the first step of a two-step run.
Oh, and there's also a tiny little commit that adds my
Deterministicbuild type to the build script. It's meant to help when users in different OSes, toolchain versions, or CPU architectures see different results.Special thanks to @victorkemp for finding and reporting this issue!