Lower DARPACK for small models#197
Merged
zchlrnr merged 2 commits intoMystranSolver:mainfrom Feb 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #121. MYSTRAN adds the parameter
DARPACK(default: 2) to the number of requested eigenvalues, and, for small models, that results in an unfeasibly largeNCV(Krylov basis size), resulting in a crash.It's a simple change: we do the
NCV"feasibility test" onEIG_N2, before settingNEV. If it fails,DARPACKis set to zero and a warning is issued.With this fix, now we pass single-element tests for
EIGRLsolutions.Thanks @victorkemp for identifying this issue!