Conversation
Collaborator
Author
|
@Bruno02468 I guess by review, I mean, ready to merge |
zchlrnr
reviewed
Apr 12, 2024
Collaborator
zchlrnr
left a comment
zchlrnr
left a comment
There was a problem hiding this comment.
All that appears to change is the removal of a premature flush command
that looks like it should have no side effects aside from checks for if files are opened
Unsure what does that in a relevant place post link 9, okay to proceed at risk
Collaborator
Author
|
To be very clear, you can't flush a closed file. It causes a segfault. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GPFORCE has a flush to the ANS file, so if ANS is closed, the code will fatal.
We should also add some all_element tests that don't use the ANS file.
fixes #65