Skip to content

Cards may now have comments in them#68

Merged
zchlrnr merged 2 commits intomainfrom
card_comment
Apr 12, 2024
Merged

Cards may now have comments in them#68
zchlrnr merged 2 commits intomainfrom
card_comment

Conversation

@SteveDoyle2
Copy link
Copy Markdown
Collaborator

Embedded card comments (see an example in 67 or the pull request test case) must start with a dollar sign. Note that a single blank character is not treated as a comment line. This fixes the PBARL fatal error that for a card line a PCOMP could result in missing layers.

fixes #67

 - lines must start with a $, so a space is not considered a comment
@SteveDoyle2 SteveDoyle2 added bug Something isn't working input labels Apr 9, 2024
@SteveDoyle2 SteveDoyle2 requested a review from Bruno02468 April 9, 2024 21:32
@zchlrnr zchlrnr self-assigned this Apr 12, 2024
@zchlrnr zchlrnr requested review from zchlrnr and removed request for Bruno02468 April 12, 2024 03:52
Copy link
Copy Markdown
Collaborator

@zchlrnr zchlrnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REC_NO=-99 is a satisfactory way to set it less than zero is what it appears to be checking for

@zchlrnr zchlrnr merged commit 3ed68ce into main Apr 12, 2024
@SteveDoyle2 SteveDoyle2 deleted the card_comment branch May 6, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cards may not have comments inside them

2 participants