New SAM metarules implementation, street network changes, & road roundabout metarules #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jflann
changed the title
- remove unnecessary adjacency - improve coverage - add draggable implementation of diag s-curve - add 3x3 street circle - match DxO T metarules to INRUL-based implementation - additional functions for curves - improved code structure
- adds INRUL based diagonal connections - eliminates diagonal connection RUL2
jflann
changed the title
…cal or Avenue networks In particular, this avoids incorrect orientations such as `Avenue~SE` and avoids flag `4`. Also fixes a diagonal SAM × orth STR crossing ID.
upgrade to Scala 3
moving NWM/HSR piece ID from 0x1700 to 0X0A00 for now.
TODO: In the future, all overrides involving 0x57041500 (O×O RHW-6S/Rail) should be removed, as those will just be unnecessary adjacencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-implements the Street Addon Mod entirely in metarules. This implementation does not create any adjacency code, but rather depends on the NAM.dll to provide adjacency funtionality.
This PR also makes some big changes to the street network:
This PR also incorporates a metarules implementation of the road roundabouts which was motivated by the necessity to change the roundabout implementation to accomodate draggable diagonal streets (#510)