Skip to content

Fix darkmode (again?)#290

Merged
h3ndofry merged 2 commits intoNAMTeam:mainfrom
noah-severyn:fix-darkmode
Feb 25, 2026
Merged

Fix darkmode (again?)#290
h3ndofry merged 2 commits intoNAMTeam:mainfrom
noah-severyn:fix-darkmode

Conversation

@noah-severyn
Copy link
Copy Markdown
Contributor

@noah-severyn noah-severyn commented Feb 14, 2026

I'm not quite sure if this solves the issue, but a long chat with Claude suggests we're missing this line: e88f13f

This was the root cause: Without this setting, Bootstrap 5.3+ doesn't generate the CSS rules that update CSS variables like --bs-warning-bg-subtle when data-bs-theme="dark" is set.

Some troubleshooting points:

  • The strange thing is everything works perfectly fine when deployed to localhost, which makes this kinda hard to test.
  • The data-bs-theme attribute does correctly toggle on the deployed site
  • I've also confirmed that both darkmode-init.js and darkmode.js in the published site are up to date, so it doesn't seem to be a caching problem with those files.

@h3ndofry h3ndofry merged commit bb5c076 into NAMTeam:main Feb 25, 2026
@noah-severyn noah-severyn deleted the fix-darkmode branch February 26, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants