Skip to content

Correct API endpoint for project approvers#489

Merged
NARKOZ merged 1 commit into
NARKOZ:masterfrom
jasonwbarnett:bugfix/merge_request_approvals
Mar 1, 2019
Merged

Correct API endpoint for project approvers#489
NARKOZ merged 1 commit into
NARKOZ:masterfrom
jasonwbarnett:bugfix/merge_request_approvals

Conversation

@jasonwbarnett
Copy link
Copy Markdown
Contributor

Updating the approvers API endpoint to align with the gitlab docs:

Reference: https://docs.gitlab.com/ee/api/merge_request_approvals.html#change-allowed-approvers

@jasonwbarnett
Copy link
Copy Markdown
Contributor Author

@NARKOZ Let me know if there is anything else I can do.

@connorshea
Copy link
Copy Markdown
Contributor

I guess #454 wasn't comprehensive enough? Why not also change the project_merge_request_approvals method?

@jasonwbarnett
Copy link
Copy Markdown
Contributor Author

jasonwbarnett commented Feb 28, 2019

#project_merge_request_approvals is already correct. I'm guessing the miss on #edit_project_merge_request_approvals was just an oversight.

@NARKOZ NARKOZ merged commit 5c61984 into NARKOZ:master Mar 1, 2019
@jasonwbarnett jasonwbarnett deleted the bugfix/merge_request_approvals branch March 1, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants