Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of NASA-AMMOS/AIT-Core#541, pickle was removed from AIT-Core.
As part of this, the output of the packet handlers was modified removing the nested pickle structure.
As a result, the AIT-GUI needed to remove the de-pickle call, which is what this PR includes.
We also updated the AIT-Core dependency to version 3.0.0 or greater, which has pickle removed.
Finally, the ait-example code was fixed so it could be run from the poetry-built launcher.
Testing included running the server with AIT-GUI and sending test telemetry from ait-example:
