Open
Conversation
|
BrianSipos
approved these changes
Apr 9, 2026
Collaborator
BrianSipos
left a comment
BrianSipos
left a comment
There was a problem hiding this comment.
Principal changes look good, only one question which can be deferred to a separate issue+PR if needed.
| BSL_TlmCounters_IncrementCounter(lib, BSL_TLM_SECOP_VERIFIER_COUNT, 1); | ||
| BSL_AbsSecBlock_Deinit(&abs_sec_block); | ||
|
|
||
| // TODO(bvb) Check postconditions that the block actually was removed |
Collaborator
There was a problem hiding this comment.
Can get rid of this, as it looks like a copy-paste, and also from wherever it was copied from. If there is a need to augment what is already here it belongs in an issue ticket.
| BSL_SecParam_t results_as_params[result_count]; | ||
| for (size_t i = 0; i < result_count; i++) | ||
| { | ||
| BSL_SecResult_t *result = BSLB_SecResultList_get(abs_sec_block.results, i); |
Collaborator
There was a problem hiding this comment.
Can use pointer-to-const to make sonar happy.
| BSL_TlmCounters_IncrementCounter(lib, BSL_TLM_SECOP_ACCEPTOR_COUNT, 1); | ||
| BSL_AbsSecBlock_Deinit(&abs_sec_block); | ||
|
|
||
| // TODO(bvb) Check postconditions that the block actually was removed |
Collaborator
There was a problem hiding this comment.
Remove this comment; policing the BPA is the job of test fixtures not the BSL.
| { | ||
| errcode = BSL_SecOper_IsRoleSource(sec_oper) == true | ||
| ? BSL_ExecBIBSource(sec_ctx->execute, lib, bundle, sec_oper, outcome) | ||
| : BSL_ExecBIBAccept(sec_ctx->execute, lib, bundle, sec_oper, outcome); |
Collaborator
There was a problem hiding this comment.
Why is there no BIB verifier branch here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151
Closes #152