Rebase Crypto Test fixtures#27
Merged
Merged
Conversation
Contributor
jeronstone
commented
Aug 5, 2025
jeronstone
commented
- Adds ability to change crypto library RNG function, which lets test cases manually set IV, generated keys
- Removes logic from sec ctxs that explicitly checks for a test fixture IV
BrianSipos
approved these changes
Aug 5, 2025
Collaborator
BrianSipos
left a comment
BrianSipos
left a comment
There was a problem hiding this comment.
Changes are good, one comment on the API doc.
billvb
reviewed
Aug 5, 2025
billvb
reviewed
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.