Skip to content

All MockBPA Tests Passing#45

Merged
jeronstone merged 34 commits into
mainfrom
bsl-33-37-38
Aug 14, 2025
Merged

All MockBPA Tests Passing#45
jeronstone merged 34 commits into
mainfrom
bsl-33-37-38

Conversation

@jeronstone
Copy link
Copy Markdown
Contributor

@jeronstone jeronstone commented Aug 8, 2025 •
edited
Loading

All Mock BPA tests now passing 🥳

@jeronstone jeronstone requested a review from a team as a code owner August 8, 2025 22:37
@BrianSipos BrianSipos added this to the BSL v1.0.0 milestone Aug 11, 2025
@BrianSipos BrianSipos added this to BSL Aug 11, 2025
@github-project-automation github-project-automation Bot moved this to Todo in BSL Aug 11, 2025
BrianSipos
BrianSipos reviewed Aug 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the current state. Nothing major.

Comment thread mock-bpa-test/_generate_simple_bundles.py
Comment thread mock-bpa-test/requirements_tests.py Outdated
Comment thread src/policy_provider/SamplePolicyProvider.h Outdated
Comment thread src/BPSecLib_Private.h Outdated
Comment thread CMakeLists.txt Outdated
@BrianSipos
Copy link
Copy Markdown
Collaborator

BrianSipos commented Aug 11, 2025

Should this PR be marked as closing #42 and #44 ?

@BrianSipos BrianSipos moved this from Todo to In Progress in BSL Aug 11, 2025
billvb
billvb reviewed Aug 11, 2025
View reviewed changes
Comment thread src/backend/SecOperation.c Outdated
billvb
billvb reviewed Aug 11, 2025
View reviewed changes
Comment thread src/backend/SecOperation.c Outdated
billvb
billvb reviewed Aug 11, 2025
View reviewed changes
Comment thread src/backend/SecOperation.c
@jeronstone jeronstone changed the title All MockBPA Tests Passing / SecOp Conclusions / PP Ordered SecOps All MockBPA Tests Passing Aug 13, 2025
perryta1
perryta1 reviewed Aug 13, 2025
View reviewed changes
Comment thread src/mock_bpa/policy_config.c
perryta1
perryta1 reviewed Aug 13, 2025
View reviewed changes
Comment thread src/backend/PublicInterfaceImpl.c Outdated
@jeronstone jeronstone requested a review from BrianSipos August 13, 2025 20:32
BrianSipos
BrianSipos approved these changes Aug 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can leave behavior as-is if the lack of PP control over decision to delete a bundle is in a bug ticket.

Comment thread src/backend/PublicInterfaceImpl.c
@jeronstone jeronstone merged commit 062e845 into main Aug 14, 2025
12 checks passed
@jeronstone jeronstone deleted the bsl-33-37-38 branch August 14, 2025 02:03
@github-project-automation github-project-automation Bot moved this from In Progress to Done in BSL Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billvb billvb billvb left review comments

@perryta1 perryta1 perryta1 left review comments

@BrianSipos BrianSipos BrianSipos approved these changes

Assignees

@jeronstone jeronstone

Labels

None yet

Projects

BSL
Status: Done

Milestone

BSL v1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jeronstone @BrianSipos @billvb @perryta1