KeyID as text string#7
Merged
Merged
Conversation
BrianSipos
reviewed
Jul 22, 2025
Collaborator
BrianSipos
left a comment
BrianSipos
left a comment
There was a problem hiding this comment.
Merge from main to get tests passing. Changes look good other than my comments.
BrianSipos
reviewed
Jul 22, 2025
Collaborator
BrianSipos
left a comment
BrianSipos
left a comment
There was a problem hiding this comment.
Some questions about memory safety, but if tests are passing memcheck that is a good signal.
billvb
reviewed
Jul 23, 2025
BrianSipos
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes KeyIDs to be textstrings (
const char*) instead of uint64s