ASB Decode - Better Error Handling#77
Merged
Merged
Conversation
billvb
reviewed
Aug 15, 2025
jeronstone
added
bug
BrianSipos
reviewed
Aug 15, 2025
Collaborator
BrianSipos
left a comment
BrianSipos
left a comment
There was a problem hiding this comment.
A suggestion and question. Also it seems like this function would be good to fuzz cover. Would you like me to add that?
…OS/BSL into asb-decode-err-handling
…bout bstr length. Cleaning up some API.
BrianSipos
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets rid of the last remaining bare assert call & allows for ASBs to have un-limited targets