Merged
Conversation
14 tasks
BrianSipos
approved these changes
Nov 20, 2024
Collaborator
BrianSipos
left a comment
There was a problem hiding this comment.
Changes themselves look good, but it looks like some test fixture library compatibility is causing problems in the CI, specifically to do with python WS client library. Do you have time look at this?
It looks like a similar problem from the past that the CI environment doesn't lock down dependency versions tightly enough and some API has changed since it was working last.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.