Skip to content

Consolidate core route for translating and sending ARI#204

Merged
DavidEdell merged 4 commits intomainfrom
feature/transcode_and_send_cmd
Jul 28, 2025
Merged

Consolidate core route for translating and sending ARI#204
DavidEdell merged 4 commits intomainfrom
feature/transcode_and_send_cmd

Conversation

@DavidEdell
Copy link
Copy Markdown
Contributor

No description provided.

@DavidEdell DavidEdell requested a review from a team as a code owner July 28, 2025 19:15
Comment thread anms-core/anms/routes/transcoder.py Fixed
Copy link
Copy Markdown
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one broader question about the usefulness of the routes which seem to just proxy to the AMP manager, if it could either just request on the manager directly?

Comment thread anms-core/anms/routes/transcoder.py Fixed
Comment thread anms-core/anms/routes/network_manager.py
Copy link
Copy Markdown
Contributor

@d-linko d-linko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only issue i ran into was the type-o i commented on. I was able to use both the UI to send ari to agents as normal and the new route to send them directly as well.

Comment thread anms-core/anms/routes/network_manager.py Outdated
@sonarqubecloud
Copy link
Copy Markdown

@DavidEdell DavidEdell merged commit bb3d9be into main Jul 28, 2025
11 checks passed
@DavidEdell DavidEdell deleted the feature/transcode_and_send_cmd branch July 28, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants