Allow sequence name to be chosen during sequence expansion filter application#1908
Merged
Conversation
JosephVolosin
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
requested changes
Apr 21, 2026
JosephVolosin
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
requested changes
Apr 22, 2026
Group reactive statements for `sequenceNameField`
duranb
approved these changes
Apr 23, 2026
dandelany
approved these changes
Apr 23, 2026
Collaborator
dandelany
left a comment
dandelany
left a comment
There was a problem hiding this comment.
@JosephVolosin we tested this and agree it fixes the main issue you brought up - so we're going to merge for today's release.
That said, there was a bit of not-sure-if-expected behavior around creating Sequences - specifically, the UI allows you to have duplicate named sequences as long as they are on different simulation datasets - this could be a bit confusing but it's not super clear what is more correct. Just wanted to call it out for future discussion.
AaronPlave
approved these changes
Apr 23, 2026
dandelany
changed the title
dandelany
changed the title
JosephVolosin
added a commit
that referenced
this pull request
Apr 23, 2026
* Allow sequence name to be chosen during filter application * Disable confirm when name is invalid * Lint * Fix validation for initial value * Declare FieldStore variables Group reactive statements for `sequenceNameField` * cleanup * Removed height specification to avoid content being cut off --------- Co-authored-by: duranb <duran.bry@gmail.com> Co-authored-by: Dan Delany <dan.delany@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when applying a sequence filter in a plan the name of the outcome sequence is auto-generated in the format of
${filter.name} Sequence (Plan ${plan.id}). This is problematic as two sequences for the same simulation cannot use the same name, but, it should be perfectly legal to apply two separate filters to a plan.This PR adds a field for the user to enter a name for the output sequence, while still using the previously mentioned format as a default. Validation is also included to not permit overlapping sequence names to be used when applying the sequence filter.