Improve sequencing server tests to login as test user before tests start#1735
Merged
Conversation
dandelany
requested review from
Mythicaeda and
mattdailis
and removed request for
DavidLegg and
skovati
|
Mythicaeda
approved these changes
Sep 4, 2025
Contributor
Mythicaeda
left a comment
Mythicaeda
left a comment
There was a problem hiding this comment.
LGTM!
I'm really curious if we forcibly rerun the test workflow on this branch if the tests flake at all, since it looks like they passed first time this time (❗)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1636 and NASA-AMMOS/plandev-gateway#132
In general, with the sequencing tests, they may be run in parallel, and multiple tests all try to run the
loginfunction in parallel. If the user doesn't exist yet, this may result in multiple attempts to create it. By logging in during the global test setup, we can ensure that the user is created and can login before any tests start running.