Skip to content

Document weblog gzip requirement and batch processing behavior#339

Merged
jordanpadams merged 1 commit intomainfrom
feature/336-document-weblog-gzip-requirement
Feb 12, 2026
Merged

Document weblog gzip requirement and batch processing behavior#339
jordanpadams merged 1 commit intomainfrom
feature/336-document-weblog-gzip-requirement

Conversation

@jordanpadams
Copy link
Copy Markdown
Member

@jordanpadams jordanpadams commented Feb 2, 2026

🗒️ Summary

Adds documentation clarifying:

  • All weblog files must be gzip-compressed (.gz) when using --weblogs
  • Pre-flight validation fails the entire request if any non-gzipped file is present
  • Workarounds: compress files or use --exclude to filter non-gzipped files
  • How batch processing works and that individual file failures do not fail the batch
  • Pre-flight validation happens before batching, so validation failures prevent all uploads

⚙️ Test Data and/or Report

See github actions run.

♻️ Related Issues

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Documentation

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.

Maintenance

  • Issue Traceability: The PR is linked to a valid GitHub Issue or Jira Ticket.
  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

Adds documentation clarifying:
- All weblog files must be gzip-compressed (.gz) when using --weblogs
- Pre-flight validation fails the entire request if any non-gzipped file is present
- Workarounds: compress files or use --exclude to filter non-gzipped files
- How batch processing works and that individual file failures do not fail the batch
- Pre-flight validation happens before batching, so validation failures prevent all uploads

Fixes #336
@jordanpadams jordanpadams requested a review from a team as a code owner February 2, 2026 16:28
Copy link
Copy Markdown
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Docs look superb.
Screenshot 2026-02-02 at 12 11 25 PM
And tox likes it too:

  py313: OK (23.18=setup[1.32]+cmd[21.87] seconds)
  docs: OK (1.18=setup[0.53]+cmd[0.65] seconds)
  lint: OK (2.63=setup[0.01]+cmd[2.62] seconds)
  congratulations :) (27.05 seconds)

Copy link
Copy Markdown
Contributor

@c-suh c-suh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated documentation beautifully explains the gzip requirement (#330) and misattributed error (#336).

@jordanpadams jordanpadams merged commit ebdc43f into main Feb 12, 2026
2 checks passed
@jordanpadams jordanpadams deleted the feature/336-document-weblog-gzip-requirement branch February 12, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload of gzip files does not happen if it is batched with non-gzip files

3 participants