Skip to content

check buffer length before copying into fixed-length buffer #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2018
Merged

check buffer length before copying into fixed-length buffer #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@

Pål-Erik Martinsen <palmarti@cisco.com>
Vladislav Volkov <wwwvladislav@gmail.com>
Marcel De Kogel <mdekogel@cisco.com>
4 changes: 4 additions & 0 deletions src/stunlib.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2553,6 +2553,10 @@ stunlib_checkIntegrity(const uint8_t* buf,
msgIntLength = msgIntLength - 8;
}

if (bufLen > STUN_MAX_PACKET_SIZE)
{
return false;
}
memcpy(&bufCopy, buf, bufLen);

/*Write new packet length in header*/
Expand Down