Escape dynamic SQL inputs in WizardService#17
Merged
NB-Core merged 1 commit intoJul 13, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds manual escaping for dynamic SQL inputs in WizardService due to the lack of parameterized query support.
- Escape input values with
addslashes()increateTranslation(),deleteUntranslated(), andsaveBatchTranslations() - Add inline comments explaining why manual escaping is used
Comments suppressed due to low confidence (1)
systems/translationwizard/translationwizard/WizardService.php:12
- There are no tests covering edge cases for SQL inputs containing quotes or special characters. Adding test cases for createTranslation, deleteUntranslated, and saveBatchTranslations would help ensure the escaping logic works as intended.
public static function createTranslation(string $language, string $namespace, string $intext, string $outtext, string $author, string $version) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createTranslation()deleteUntranslated()saveBatchTranslations()Testing
git status --shorthttps://chatgpt.com/codex/tasks/task_e_6873e4c0f9c0832989c0e07fce9a9f7a