Skip to content

Inline translationwizard hook handler#24

Merged
NB-Core merged 3 commits into
tlwizardfrom
codex/move-switch-block-to-translationwizard.php
Jul 13, 2025
Merged

Inline translationwizard hook handler#24
NB-Core merged 3 commits into
tlwizardfrom
codex/move-switch-block-to-translationwizard.php

Conversation

@NB-Core
Copy link
Copy Markdown
Owner

@NB-Core NB-Core commented Jul 13, 2025

Summary

  • merge the contents of translationwizard_dohook.php into translationwizard.php
  • remove obsolete file translationwizard_dohook.php

Testing

  • php -l systems/translationwizard/translationwizard.php

https://chatgpt.com/codex/tasks/task_e_687417b793ac8329b66d819e50ca7cff

@NB-Core NB-Core requested a review from Copilot July 13, 2025 20:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges the standalone hook handler into the main module file and removes the now-redundant translationwizard_dohook.php.

  • Inlined the switch-based hook logic directly into translationwizard_dohook() in translationwizard.php
  • Deleted the obsolete translationwizard_dohook.php file

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
systems/translationwizard/translationwizard/translationwizard_dohook.php Entire file removed as its contents are now inlined
systems/translationwizard/translationwizard.php Added inlined hook handler; removed external require
Comments suppressed due to low confidence (1)

systems/translationwizard/translationwizard.php:109

  • Consider adding unit or integration tests for the newly inlined hook logic to ensure each hook case (superuser, header-modules, etc.) behaves as expected.
        switch ($hookname) {

Comment thread systems/translationwizard/translationwizard.php Outdated
Comment thread systems/translationwizard/translationwizard.php Outdated
NB-Core and others added 2 commits July 13, 2025 22:40
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@NB-Core NB-Core merged commit 54179a9 into tlwizard Jul 13, 2025
@NB-Core NB-Core deleted the codex/move-switch-block-to-translationwizard.php branch July 13, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants