Inline translationwizard hook handler#24
Merged
NB-Core merged 3 commits intoJul 13, 2025
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges the standalone hook handler into the main module file and removes the now-redundant translationwizard_dohook.php.
- Inlined the switch-based hook logic directly into
translationwizard_dohook()intranslationwizard.php - Deleted the obsolete
translationwizard_dohook.phpfile
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| systems/translationwizard/translationwizard/translationwizard_dohook.php | Entire file removed as its contents are now inlined |
| systems/translationwizard/translationwizard.php | Added inlined hook handler; removed external require |
Comments suppressed due to low confidence (1)
systems/translationwizard/translationwizard.php:109
- Consider adding unit or integration tests for the newly inlined hook logic to ensure each hook case (
superuser,header-modules, etc.) behaves as expected.
switch ($hookname) {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
translationwizard_dohook.phpintotranslationwizard.phptranslationwizard_dohook.phpTesting
php -l systems/translationwizard/translationwizard.phphttps://chatgpt.com/codex/tasks/task_e_687417b793ac8329b66d819e50ca7cff