Add strict types to Specialty System

[NB-Core]

Summary

• enable strict typing in specialty system modules
• add typed parameters and return types
• document all functions with docblocks

Testing

• php -l systems/specialtysystem/specialtysystem_wind.php
• php -l systems/specialtysystem/specialtysystem/functions.php
• php -l systems/specialtysystem/specialtysystem/datafunctions.php
• php -l systems/specialtysystem/specialtysystem/register.php
• php -l systems/specialtysystem/specialtysystem/uninstall.php
• php -l systems/specialtysystem/specialtysystem_water.php
• php -l systems/specialtysystem/specialtysystem_sand.php
• php -l systems/specialtysystem/specialtysystem_medical.php
• php -l systems/specialtysystem/specialtysystem.php
• php -l systems/specialtysystem/specialtysystem_fire.php
• php -l systems/specialtysystem/specialtysystem_lightning.php
• php -l systems/specialtysystem/specialtysystem_ice.php
• php -l systems/specialtysystem/specialtysystem_basic.php
• php -l systems/specialtysystem/specialtysystem_genjutsu.php
• php -l systems/specialtysystem/specialtysystem_earth.php

---

https://chatgpt.com/codex/tasks/task_e_68767274371c832984104e297552b20d

[Copilot]

Pull Request Overview

This PR enables strict typing and improves documentation for the Specialty System modules, ensuring explicit parameter and return types and adding docblocks to all functions.

• Added declare(strict_types=1) to all module and helper files
• Updated function signatures with typed parameters and return types
• Inserted PHPDoc docblocks for better code clarity and IDE support

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
systems/specialtysystem/specialtysystem_wind.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem_water.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem_sand.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem_medical.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem_lightning.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem_ice.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem_genjutsu.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem_fire.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem_earth.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem_basic.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem/uninstall.php	Add strict types and docblock
systems/specialtysystem/specialtysystem/register.php	Add strict types, adjust return usage, and docblock
systems/specialtysystem/specialtysystem/functions.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem/datafunctions.php	Add strict types, typed signatures, and docblocks
systems/specialtysystem/specialtysystem.php	Add strict types, typed signatures, and docblocks

Comments suppressed due to low confidence (3)

systems/specialtysystem/specialtysystem/functions.php:130

• The check if (is_array('name')) is always false since 'name' is a string literal. It should likely verify that $specialtycollector is an array, e.g., if (is_array($specialtycollector)) {

/**

systems/specialtysystem/specialtysystem_wind.php:85

• Docblock for specialtysystem_wind_apply is missing a @return void annotation. Please add it to reflect the function's return type.

 * @param string $skillname

systems/specialtysystem/specialtysystem/register.php:29

• Function specialtysystem_register no longer returns the result of db_query(), which may break existing callers expecting a boolean return. Consider restoring the return or updating callers and the docblock to reflect a void return.

        db_query($sql);