Conversation
* chore: initialize project structure * chore: initialize project structure * chore: initialize project structure * fix: 엔티티 오류수정 및 설정파일 오류 수정 * 📝 Add docstrings to `dev` (#3) Docstrings generation was requested by @Ksr-ccb. * #2 (comment) The following files were modified: * `src/main/java/com/example/cs25/domain/ai/exception/AiException.java` * `src/main/java/com/example/cs25/domain/mail/entity/MailLog.java` * `src/main/java/com/example/cs25/domain/mail/exception/MailException.java` * `src/main/java/com/example/cs25/domain/oauth/exception/OauthException.java` * `src/main/java/com/example/cs25/domain/quiz/exception/QuizException.java` * `src/main/java/com/example/cs25/domain/userQuizAnswer/entity/UserQuizAnswer.java` * `src/main/java/com/example/cs25/domain/userQuizAnswer/exception/UserQuizAnswerException.java` * `src/main/java/com/example/cs25/domain/users/entity/User.java` * `src/main/java/com/example/cs25/domain/users/exception/UserException.java` * `src/main/java/com/example/cs25/domain/users/vo/Subscription.java` * `src/main/java/com/example/cs25/global/exception/BaseException.java` * `src/main/java/com/example/cs25/global/exception/GlobalExceptionHandler.java` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* refactor: ERD 수정으로 인한 Entity 수정. * refactor: ERD 수정으로 인한 Entity 수정2.
This reverts commit 3ca826f.
# Conflicts: # .github/workflows/run-test.yaml # build.gradle # docker-compose.yml # src/main/java/com/example/cs25/domain/users/controller/UserController.java # src/main/java/com/example/cs25/domain/users/entity/SocialType.java # src/main/java/com/example/cs25/domain/users/entity/User.java # src/main/java/com/example/cs25/domain/users/exception/UserExceptionCode.java # src/main/java/com/example/cs25/domain/users/repository/UserRepository.java # src/main/resources/application.properties
Walkthrough배포 워크플로우에서 원격 서버에 설치되는 Java 버전이 21에서 17로 변경되었습니다. 또한, MySQL 및 Redis 서비스를 정의하던 docker-compose.yml 파일이 전체 삭제되었습니다. 공개 엔티티 선언에는 변경이 없습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Remote Server
GitHub Actions->>Remote Server: sudo yum install -y java-17-amazon-corretto
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 2
🧹 Nitpick comments (2)
.github/workflows/deploy.yml (2)
21-21: 선택: Java 배포판 지정 갱신
distribution: 'adopt'은 향후 deprecation 될 수 있으므로, Temurin 또는 Corretto 등 LTS 배포판으로 변경을 검토하세요.예시:
- distribution: 'adopt' + distribution: 'temurin'
56-56: 개행 누락 감지
파일 끝에 개행(newline)이 없습니다. POSIX 호환성과 일부 lint 툴 경고를 방지하려면 파일 끝에 빈 줄 또는 개행을 추가하세요.예시:
+🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 56-56: no new line character at the end of file
(new-line-at-end-of-file)
🛑 Comments failed to post (2)
.github/workflows/deploy.yml (2)
30-30: 🛠️ Refactor suggestion
버전 고정 필요: scp-action 안정성 확보
appleboy/scp-action@master대신 특정 릴리즈 태그로 고정해야 의존 액션의 예기치 않은 변경으로 인한 배포 실패를 방지할 수 있습니다.예시:
- uses: appleboy/scp-action@master + uses: appleboy/scp-action@v0.1.4📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.uses: appleboy/scp-action@v0.1.4🤖 Prompt for AI Agents
In .github/workflows/deploy.yml at line 30, the usage of appleboy/scp-action is pinned to the 'master' branch, which risks instability due to unexpected changes. Replace 'appleboy/scp-action@master' with a specific release tag version to ensure consistent and reliable deployment behavior.
26-27:
⚠️ Potential issue치명적: 테스트 단계 누락
현재 워크플로우에 단위 테스트 실행 단계가 없어, 테스트 실패에도 불구하고 빌드 및 배포가 진행될 위험이 있습니다. 배포 전 반드시./gradlew test를 실행하도록 테스트 단계를 추가하세요.예시:
- - name: gradlew bootJar - run: ./gradlew bootJar + - name: Run Tests + run: ./gradlew test + - name: gradlew bootJar + run: ./gradlew bootJar📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.- name: Run Tests run: ./gradlew test - name: gradlew bootJar run: ./gradlew bootJar🤖 Prompt for AI Agents
In .github/workflows/deploy.yml around lines 26 to 27, the workflow lacks a test step before building and deploying, which risks deploying broken code. Add a step to run './gradlew test' before the 'gradlew bootJar' step to ensure unit tests pass before proceeding with the build and deployment.
4 participants
Summary by CodeRabbit
closed #15