chore: MCP Brave Search 관련 Dockerfile도 롤백#396
Merged
wannabeing merged 1 commit intodevfrom Aug 12, 2025
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. Walkthroughcs25-service/Dockerfile를 정리하여 Gradle 빌드에서 테스트 스킵 옵션 제거, MCP 관련 ENV 및 Brave Search 수동 래핑 제거, npm 글로벌 설치의 버전 고정 해제, apt 캐시 정리 추가로 이미지 클린업을 강화했습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Docker as Docker Builder
participant OS as Build Image
participant NPM as npm Registry
participant Gradle as Gradle
Docker->>OS: apt-get install dependencies
Docker->>NPM: npm install -g @modelcontextprotocol/server-brave-search
Docker->>Gradle: ./gradlew :cs25-service:bootJar --stacktrace --no-daemon
Gradle-->>Docker: Produce bootJar (tests not explicitly skipped)
Docker->>OS: apt-get purge/autoremove && clean && rm -rf /var/lib/apt/lists/*
OS-->>Docker: Slimmed image layers
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
crocusia
approved these changes
Aug 12, 2025
Kimyoonbeom
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔎 작업 내용
🛠️ 변경 사항
UserService.createUser()메서드 추가@Email유효성 검증 적용🧩 트러블 슈팅
@Transactional이 적용되지 않음this.→AopProxyUtils.사용)🧯 해결해야 할 문제
UserController에서 비즈니스 로직 일부 처리 → 서비스로 이전 고려 필요📌 참고 사항
🙏 코드 리뷰 전 확인 체크리스트
type :)Summary by CodeRabbit