Skip to content

chore: MCP Brave Search 관련 Dockerfile도 롤백#396

Merged
wannabeing merged 1 commit intodevfrom
fix/mcp-settings
Aug 12, 2025
Merged

chore: MCP Brave Search 관련 Dockerfile도 롤백#396
wannabeing merged 1 commit intodevfrom
fix/mcp-settings

Conversation

@wannabeing
Copy link
Member

@wannabeing wannabeing commented Aug 12, 2025

🔎 작업 내용

  • �Dockerfile도 롤백했습니다.

🛠️ 변경 사항

  • 구현한 주요 로직, 클래스, 메서드 등을 bullet 형식으로 기술해주세요.
  • 예)
    • UserService.createUser() 메서드 추가
    • @Email 유효성 검증 적용

🧩 트러블 슈팅

  • 구현 중 마주한 문제와 해결 방법을 기술해주세요.
  • 예)
    • 문제: @Transactional이 적용되지 않음
    • 해결: 메서드 호출 방식 변경 (this.AopProxyUtils. 사용)

🧯 해결해야 할 문제

  • 기능은 동작하지만 리팩토링이나 논의가 필요한 부분을 적어주세요.
  • 예)D
    • UserController에서 비즈니스 로직 일부 처리 → 서비스로 이전 고려 필요

📌 참고 사항

  • 기타 공유하고 싶은 정보나 참고한 문서(링크 등)가 있다면 작성해주세요.

🙏 코드 리뷰 전 확인 체크리스트

  • 불필요한 콘솔 로그, 주석 제거
  • 커밋 메시지 컨벤션 준수 (type : )
  • 기능 정상 동작 확인

Summary by CodeRabbit

  • 신규 기능
    • 해당 없음
  • 리팩터
    • 불필요한 환경 설정을 제거하고 빌드 절차를 단순화하여 안정성을 향상했습니다.
  • 잡무(Chores)
    • 이미지 최적화 작업으로 용량을 줄여 배포 속도와 효율을 개선했습니다.
    • 외부 검색 구성 요소 설치 방식을 표준화하여 유지보수성을 높였습니다.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 12, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

cs25-service/Dockerfile를 정리하여 Gradle 빌드에서 테스트 스킵 옵션 제거, MCP 관련 ENV 및 Brave Search 수동 래핑 제거, npm 글로벌 설치의 버전 고정 해제, apt 캐시 정리 추가로 이미지 클린업을 강화했습니다.

Changes

Cohort / File(s) Change Summary
Gradle 빌드 경로 조정
cs25-service/Dockerfile
Gradle bootJar 실행에서 -x test 제거, 명령을 ./gradlew :cs25-service:bootJar --stacktrace --no-daemon로 단순화. Gradle wrapper chmod 제거.
MCP/Brave Search 설치 방식 변경
cs25-service/Dockerfile
MCP 관련 ENV 제거. @modelcontextprotocol/server-brave-search 글로벌 설치에서 버전 고정, 수동 심볼릭 링크, 실행 확인(—help) 절차 제거하고 단순 npm install -g만 유지.
이미지 클린업 강화
cs25-service/Dockerfile
apt-get purge/autoremove 이후 apt-get clean/var/lib/apt/lists/* 제거 추가로 레이어 정리.

Sequence Diagram(s)

sequenceDiagram
  participant Docker as Docker Builder
  participant OS as Build Image
  participant NPM as npm Registry
  participant Gradle as Gradle

  Docker->>OS: apt-get install dependencies
  Docker->>NPM: npm install -g @modelcontextprotocol/server-brave-search
  Docker->>Gradle: ./gradlew :cs25-service:bootJar --stacktrace --no-daemon
  Gradle-->>Docker: Produce bootJar (tests not explicitly skipped)
  Docker->>OS: apt-get purge/autoremove && clean && rm -rf /var/lib/apt/lists/*
  OS-->>Docker: Slimmed image layers
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • jong-0126
  • Ksr-ccb
  • Kimyoonbeom
  • crocusia
  • HeeMang-Lee

Poem

살금살금 도커 속, 토끼는 레이어를 깎고 또 깎네 🐇
버전핀은 훅— 풀고, 링크 줄도 말끔히 정리!
gradle은 또각또각, 테스트는 그대로 보폭 맞추고—
apt 바람 쓱— 캐시 먼지 훌훌.
가벼워진 이미지에 깡총, 배포로 뛰어간다! ✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55aa066 and 37782ac.

📒 Files selected for processing (1)
  • cs25-service/Dockerfile (2 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/mcp-settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wannabeing wannabeing merged commit ec70200 into dev Aug 12, 2025
1 of 2 checks passed
@wannabeing wannabeing deleted the fix/mcp-settings branch August 12, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants