Skip to content

Conversation

@jjguerrette
Copy link

Description

Update build/CMakeLists.txt to prepare for new release tag.

Issue closed

Closes #209

Tests completed

No impact

@jjguerrette jjguerrette requested a review from liujake April 3, 2023 18:03
@jjguerrette
Copy link
Author

@liujake, I do not have access to SACA and do not know what the hash should be.

@junmeiban
Copy link
Collaborator

Tested.

@byoung-joo
Copy link
Collaborator

@jjguerrette , please set 5f62db0 for SACA.

Copy link
Collaborator

@liujake liujake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As saca is not build by default. No need to worry about its hash. Leave it as 'develop' is Ok.

@liujake
Copy link
Collaborator

liujake commented Apr 3, 2023

Just saw saca hash was provided. Do either way fine with me.

@jjguerrette jjguerrette merged commit 90583a9 into develop Apr 3, 2023
@jjguerrette jjguerrette deleted the release/22MAR2023 branch April 3, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create release tag for 22MAR2023 build

5 participants