Conversation
Contributor
|
📄 Documentation for this branch is available at: https://ncar.github.io/MechanismConfiguration/branch/msys2_tests/ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 3 3
Lines 23 23
=======================================
Hits 20 20
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds MSYS2 build support to the existing Windows CI workflow to help debug failures observed in the musica project. The changes expand the Windows testing matrix to include both MSVC and MSYS2 toolchains.
- Renames the existing Windows job from "build-and-test" to "msvc" for clarity
- Adds Debug build configuration to the MSVC build matrix
- Introduces a new "msys2" job that builds and tests using the MinGW toolchain
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mattldawson
approved these changes
Aug 13, 2025
boulderdaze
approved these changes
Aug 13, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a failing action on musica on mysy2 specifically in debug. I thought I could replicate it here. I can't, but it's still a good test to add