Skip to content

46 implement yaml parsing#52

Merged
mattldawson merged 7 commits intomainfrom
46-implement-yaml-parsing
Jan 16, 2025
Merged

46 implement yaml parsing#52
mattldawson merged 7 commits intomainfrom
46-implement-yaml-parsing

Conversation

@K20shores
Copy link
Copy Markdown
Collaborator

Closes #46, closes #45

  • Prefixes all build options with OPEN_ATMOS_
  • Removes nlohmann::json in favor of yaml-cpp
  • Duplicated all json files into a yaml equivalent and made each test parse both and ensure we get the same answers
  • split out each parsers into its own file

@K20shores K20shores linked an issue Jan 15, 2025 that may be closed by this pull request
16 tasks
Copy link
Copy Markdown
Contributor

@boulderdaze boulderdaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Comment thread CMakeLists.txt
Copy link
Copy Markdown
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mattldawson mattldawson merged commit dae56fd into main Jan 16, 2025
@mattldawson mattldawson deleted the 46-implement-yaml-parsing branch January 16, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement yaml parsing Prefix all cmake options with OpenAtmos_

3 participants