Update namespace and targets in packaging#83
Conversation
| DESTINATION | ||
| ${cmake_config_install_location} | ||
| NAMESPACE open_atmos:: | ||
| NAMESPACE mechanism_configuration:: |
There was a problem hiding this comment.
| NAMESPACE mechanism_configuration:: | |
| NAMESPACE musica:: |
In micm and tuvx, we use musica for the namespace. Perhaps we should do the same here
- https://github.com/NCAR/micm/blob/main/src/CMakeLists.txt#L8
- https://github.com/NCAR/tuv-x/blob/main/src/CMakeLists.txt#L40
We will also need to change it in the file that defines the cmake library
https://github.com/NCAR/MechanismConfiguration/blob/main/src/CMakeLists.txt#L6
There was a problem hiding this comment.
Ah, that's a good point. Updated.
How about the prefix of the CMake options?
option(OPEN_ATMOS_ENABLE_TESTS "Build the tests" ON)
option(OPEN_ATMOS_ENABLE_PYTHON_LIBRARY "Build the python library" ON)
option(OPEN_ATMOS_ENABLE_PIC "Build the library with position independent code" ON)
https://github.com/NCAR/MechanismConfiguration/blob/main/CMakeLists.txt#L24-L26
There was a problem hiding this comment.
Yeah, we may as well go ahead and change those. Typically we prefix those with the name of the reposiry (musica uses MUSICA, micm uses MICM). I gess MECH_CONFIG would be a good prefix? I'm open to whatever you think is good
There was a problem hiding this comment.
I like that. Yeah let me include them in this PR.
2 participants
Updated namespace and installation target script in packaging