Skip to content

removing python build#95

Merged
K20shores merged 3 commits intomainfrom
remove_python
May 8, 2025
Merged

removing python build#95
K20shores merged 3 commits intomainfrom
remove_python

Conversation

@K20shores
Copy link
Copy Markdown
Collaborator

We found it better to put the python bindings directly into musica, since that's really the only package that will use it anyways. That is done in NCAR/musica#328

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the standalone Python build for mechanism_configuration in favor of integrating the Python bindings directly into musica. Key changes include:

  • Removal of Python build configurations and targets from various CMakeLists.txt files.
  • Deletion of Python-specific files (pyproject.toml, mechanism_configuration/init.py, mechanism_configuration/CMakeLists.txt) and related workflow configurations.
  • Cleanup of dependency management by eliminating the pybind11 fetch block.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/CMakeLists.txt Removed the condition for building Python bindings alongside PIC.
pyproject.toml Entire file removed as Python build is no longer needed.
mechanism_configuration/init.py Removed all Python binding entry points.
mechanism_configuration/CMakeLists.txt Removed Python module build configuration.
cmake/dependencies.cmake Deleted pybind11 dependency fetch block due to removal of Python.
README.md Removed the PyPI badge to reflect the discontinued Python package.
CMakeLists.txt (top-level) Removed Python build option and subdirectory addition; adjusted packaging logic.
.github/workflows/python.yml Removed workflow for testing Python builds.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.95%. Comparing base (a612265) to head (2de0f56).
⚠️ Report is 99 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files           3        3           
  Lines          23       23           
=======================================
  Hits           20       20           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@K20shores K20shores merged commit dab4832 into main May 8, 2025
15 checks passed
@K20shores K20shores deleted the remove_python branch May 8, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants