Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the standalone Python build for mechanism_configuration in favor of integrating the Python bindings directly into musica. Key changes include:
- Removal of Python build configurations and targets from various CMakeLists.txt files.
- Deletion of Python-specific files (pyproject.toml, mechanism_configuration/init.py, mechanism_configuration/CMakeLists.txt) and related workflow configurations.
- Cleanup of dependency management by eliminating the pybind11 fetch block.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/CMakeLists.txt | Removed the condition for building Python bindings alongside PIC. |
| pyproject.toml | Entire file removed as Python build is no longer needed. |
| mechanism_configuration/init.py | Removed all Python binding entry points. |
| mechanism_configuration/CMakeLists.txt | Removed Python module build configuration. |
| cmake/dependencies.cmake | Deleted pybind11 dependency fetch block due to removal of Python. |
| README.md | Removed the PyPI badge to reflect the discontinued Python package. |
| CMakeLists.txt (top-level) | Removed Python build option and subdirectory addition; adjusted packaging logic. |
| .github/workflows/python.yml | Removed workflow for testing Python builds. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 3 3
Lines 23 23
=======================================
Hits 20 20
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattldawson
approved these changes
May 8, 2025
boulderdaze
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found it better to put the python bindings directly into musica, since that's really the only package that will use it anyways. That is done in NCAR/musica#328