Bugfix for unpromoted ddt-type scalar variables#626
Merged
mkavulich merged 2 commits intoNCAR:developfrom Jan 27, 2025
Merged
Conversation
peverwhee
requested review from
climbfuji,
dustinswales,
gold2718,
grantfirl,
mkavulich and
mwaxmonsky
as code owners
climbfuji
approved these changes
Jan 23, 2025
dustinswales
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where a ddt used in only one phase (thereby not promoted to the group level) does not get the necessary "use" statement added at the subroutine level in the suite cap.
Updates
M scripts/suite_objects.py
User interface changes?: No
Testing:
test removed: n/a
unit tests: all pass
system tests: all pass
manual testing: ran w/ scalar ddt in CAM-SIMA