Add Google-style docstrings and fix bugs in core modules#92
Merged
zaihuaji merged 1 commit intohua-work-commonfrom Mar 21, 2026
Merged
Add Google-style docstrings and fix bugs in core modules#92zaihuaji merged 1 commit intohua-work-commonfrom
zaihuaji merged 1 commit intohua-work-commonfrom
Conversation
- pg_dbi.py: Added docstrings to all 60+ methods; fixed pgbatch uninitialized dict, get_specialist wrong cache key, validate_decs_group wrong variable name - pg_util.py: Added docstrings to all 54 methods; fixed get_wday NameError, fmtdatetime shadowed built-in str, addyearmonth overwritten params, duplicate adddatetime definition, addtime wrong assignment target, joinarray bare int in for loop, asearch float division index, endtime attribute access typo, and two == None identity checks - pg_file.py: Added docstrings to all 80+ methods; fixed remote_copy_local dead code after return, record_delete_directory missing re.match arg, compare_md5sum wrong files arg, convert_files op.exist() typo, make_one_backup_directory undefined ret, check_local_executable wrong os.W_OK permission flag - pg_sig.py: Added docstrings to all methods; fixed os.sleep/sys.sleep -> time.sleep, extra self arg in check_process call, get_pbs_info wrong ckeys index, check_background dict mutation during iteration, get_wait_time undefined unit variable fallback Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
time.sleep, extra self arg in check_process call, get_pbs_info wrong ckeys index, check_background dict mutation during iteration, get_wait_time undefined unit variable fallback