Add Google-style docstrings and fix bugs in pg_cmd, pg_lock, pg_opt, …#93
Merged
zaihuaji merged 1 commit intohua-work-commonfrom Mar 21, 2026
Merged
Add Google-style docstrings and fix bugs in pg_cmd, pg_lock, pg_opt, …#93zaihuaji merged 1 commit intohua-work-commonfrom
zaihuaji merged 1 commit intohua-work-commonfrom
Conversation
…pg_split pg_cmd.py: - Added docstrings to all methods and class - Fixed unescaped dot in dsid regex (r'^(ds\d|\d)\d\d.\d$' -> r'...\.\d$') - Fixed NoneType concatenation crash in get_dynamic_options when SYSERR is None pg_lock.py: - Added docstrings to all methods and class - Fixed update_partition_lock: pid counter underflow (added max(0, ...)) - Fixed update_partition_lock: potential KeyError on missing 'pid' key - Fixed update_partition_lock: inconsistent early-return value (0 -> None) - Fixed lock_process_info: implicit None check -> explicit is not None pg_opt.py: - Added docstrings to all 40+ methods and class - Fixed set_sudo_uid/set_root_uid: self.params['CACT'] -> self.PGOPT['CACT'] - Fixed set_sudo_uid/set_root_uid: missing closing quote in format strings - Fixed set_option_value: str builtin used instead of local variable dstr - Fixed validate_one_infile: == None -> is None - Fixed get_control_frequency: wrong return value on error (returned unit char instead of error message string) - Fixed append_format_string: unescaped regex metacharacters in fmt pg_split.py: - Added docstrings to all methods and class - Fixed compare_wfile: [[]]*flen shallow copy bug (all fields shared one list) - Fixed compare_wfile: dsrecs.keys() live view -> list(dsrecs.keys()) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…pg_split
pg_cmd.py:
pg_lock.py:
pg_opt.py:
pg_split.py: