Feature #177 add wind speed contour plots that were removed#185
Merged
georgemccabe merged 4 commits intodevelopfrom Apr 6, 2023
Merged
Feature #177 add wind speed contour plots that were removed#185georgemccabe merged 4 commits intodevelopfrom
georgemccabe merged 4 commits intodevelopfrom
Conversation
…ist, changed display names to discern wind vector/speed and note 3D field
fossell
requested changes
Apr 6, 2023
Collaborator
fossell
left a comment
There was a problem hiding this comment.
@georgemccabe - The changes look good, please see comments and suggested changes for the color range. I think we missed that when switching from m/s to kts. Our original range when we had m/s was 0-60m/s for 10-meter wind speed, so when moving to kts is should almost double to 120. We will likely need to make custom ranges for each veritcal level, but I think @hahnd might be able to address this in #162 which likely has similar issues.
Also, thanks for adding the "vector" to the label for wind direction, that makes it much clearer.
Co-authored-by: Kate Fossell <fossell@ucar.edu>
Co-authored-by: Kate Fossell <fossell@ucar.edu>
fossell
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #177
Expected Differences
Wind speed contour plots are now available again
Pull Request Testing
Started a cluster and ran a job to test changes. Output can be displayed here:
https://app.wrfcloud.com/view/W63E889AE4D
Review wind speed plots on https://app.wrfcloud.com/view/W63E889AE4D
Updated product list
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
Please complete this pull request review by 4/10/2023.
Pull Request Checklist
Select: Reviewer(s)
Select: Project
Select: Milestone as the version that will include these changes
Select: Development to link to the original development issue.