Skip to content

Feature #177 add wind speed contour plots that were removed#185

Merged
georgemccabe merged 4 commits intodevelopfrom
feature/177_restore_wind_speed
Apr 6, 2023
Merged

Feature #177 add wind speed contour plots that were removed#185
georgemccabe merged 4 commits intodevelopfrom
feature/177_restore_wind_speed

Conversation

@georgemccabe
Copy link
Collaborator

Closes #177

Expected Differences

  • Do these changes modify the system output in any way? [Yes]

Wind speed contour plots are now available again

Pull Request Testing

  • Describe testing already performed for these changes:

Started a cluster and ran a job to test changes. Output can be displayed here:
https://app.wrfcloud.com/view/W63E889AE4D

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review wind speed plots on https://app.wrfcloud.com/view/W63E889AE4D

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

Updated product list

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 4/10/2023.

Pull Request Checklist

  • Review the source issue metadata (labels, project, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Project
    Select: Milestone as the version that will include these changes
    Select: Development to link to the original development issue.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…ist, changed display names to discern wind vector/speed and note 3D field
@georgemccabe georgemccabe added this to the Version 1.X milestone Apr 5, 2023
@georgemccabe georgemccabe requested a review from fossell April 5, 2023 22:13
Copy link
Collaborator

@fossell fossell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@georgemccabe - The changes look good, please see comments and suggested changes for the color range. I think we missed that when switching from m/s to kts. Our original range when we had m/s was 0-60m/s for 10-meter wind speed, so when moving to kts is should almost double to 120. We will likely need to make custom ranges for each veritcal level, but I think @hahnd might be able to address this in #162 which likely has similar issues.

Also, thanks for adding the "vector" to the label for wind direction, that makes it much clearer.

georgemccabe and others added 2 commits April 6, 2023 09:28
Co-authored-by: Kate Fossell <fossell@ucar.edu>
Co-authored-by: Kate Fossell <fossell@ucar.edu>
@georgemccabe georgemccabe requested a review from fossell April 6, 2023 15:29
@georgemccabe georgemccabe merged commit 8d24f1a into develop Apr 6, 2023
@georgemccabe georgemccabe deleted the feature/177_restore_wind_speed branch April 6, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reinstate color contoured wind speed products

2 participants