Merged
Conversation
fossell
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Differences
Updated to latest version of buildspec.
Added quotes around variables in the buildspec to prevent possible word-splitting.
Changed default build branch to "develop".
Updated Dockerfile for test container to work with the latest amazonlinux image. This required installing additional OS packages that are no longer present; an
d changing how NPM and ng-cli are installed and configured.
Fixed the coverage script to include all python files, and do not open a browser window when in the container.
Disabled some pylint errors, since we will not have pygrib installed in the container.
Commented-out some tests that require access to S3 account resources and beyond.
Fixed a DynamoDB test -- table deletion was failing.
Added an error at start of Dockerbuild if user is building the image on an ARM architecture. x86_64 is required for AWS CodeBuild compatibility.
** Added code to remove pygrib dependency, as this would require installing compilers in the container and building all grib library dependencies. @fossell - Do we want to spend time on updating the test container?
Pull Request Testing
Describe testing already performed for these changes:
Deployed to AWS account and tested.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Start a new build and see if it runs successfully.
Check CodeCov.io link from main README.md.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
Select: Reviewer(s)
Select: Project
Select: Milestone as the version that will include these changes
Select: Development to link to the original development issue.
Closes #95.