Skip to content

Bug/95 code build#192

Merged
hahnd merged 14 commits intodevelopfrom
bug/95-code-build
Apr 21, 2023
Merged

Bug/95 code build#192
hahnd merged 14 commits intodevelopfrom
bug/95-code-build

Conversation

@hahnd
Copy link
Collaborator

@hahnd hahnd commented Apr 21, 2023

Expected Differences

Updated to latest version of buildspec.
Added quotes around variables in the buildspec to prevent possible word-splitting.
Changed default build branch to "develop".
Updated Dockerfile for test container to work with the latest amazonlinux image. This required installing additional OS packages that are no longer present; an
d changing how NPM and ng-cli are installed and configured.
Fixed the coverage script to include all python files, and do not open a browser window when in the container.
Disabled some pylint errors, since we will not have pygrib installed in the container.
Commented-out some tests that require access to S3 account resources and beyond.
Fixed a DynamoDB test -- table deletion was failing.
Added an error at start of Dockerbuild if user is building the image on an ARM architecture. x86_64 is required for AWS CodeBuild compatibility.

** Added code to remove pygrib dependency, as this would require installing compilers in the container and building all grib library dependencies. @fossell - Do we want to spend time on updating the test container?

Pull Request Testing

  • Describe testing already performed for these changes:

    Deployed to AWS account and tested.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Start a new build and see if it runs successfully.
    Check CodeCov.io link from main README.md.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

  • Review the source issue metadata (labels, project, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Project
    Select: Milestone as the version that will include these changes
    Select: Development to link to the original development issue.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Closes #95.

@hahnd hahnd added the component: testing Software testing issue label Apr 21, 2023
@hahnd hahnd added this to the Version 1.1 milestone Apr 21, 2023
@hahnd hahnd requested a review from fossell April 21, 2023 16:08
@hahnd hahnd merged commit 9150fd9 into develop Apr 21, 2023
@hahnd hahnd deleted the bug/95-code-build branch April 21, 2023 22:17
@fossell fossell modified the milestones: Version 1.1, Version 1.X May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: testing Software testing issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS CodeBuild fails - need node installed

2 participants