Conversation
Propagate namelist changes from text edit. Added namelist parser and unparser. Setup events appropriately to pass user changes to all other data representations.
* develop: (39 commits) Feature #188 restrict dates in forecast selector (#213) change precip accum color bar to viridis (#215) use evenly spaced font for logs fix bug showing actual value of email notify setting in job details view by adding notify to list of keys to pass fix bug getting nx/ny values that are incorrect when multiple domains are specified revert change to docs because we are not renaming logs zip file move exit button to top right for log viewer, override sort of keys for log file list, replace disabled button with span with set pixel width make Logs button blue and change Close button to an X icon on the top right of window added option to wrfcloud-run to skip deletion of cluster for running on by hand cluster fix bug in email notify logic by adding setting expected env var used to send email change logs zip file name back to exclude job ID since it can be added when the user downloads it improve formatting and display current log file as label of text area create job data directory to write wrfcloud log into it prevent error if user clicks on Loading Logs text before log list has been loaded write wrfcloud runtime log file into job directory so all files for a job are contained in the same directory and simplifies logic to get log files for log viewer add job ID to logs zip file so it is clear what it contains if/when we allow users to download it cleanup store name of log with directory to find file from tree selector store full name of log file so it can be easily referenced when viewing the file replace sidenav with tree for log viewer ... # Conflicts: # web/src/app/app.module.ts
Added computation for time_step in wrf namelist. Added default (or template) namelists for new configurations.
hahnd
added
component: web ui
component: NWP components
Collaborator
Author
|
Reviewed during a couple of meetings. Merging now. |
Collaborator
|
Closes #144 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected Differences
WRF configuration editing by GUI is enabled.
Pull Request Testing
Namelist data is represented in three places:
As you change variables listed below in one place, the other two should stay in sync.
Valid namelist files should be generated.
Variables:
Focus on web/src/app/model-config/default-namelists.ts as this file has template/default namelists.
Pull Request Checklist
Select: Reviewer(s)
Select: Project
Select: Milestone as the version that will include these changes
Select: Development to link to the original development issue.